Use default max_lines when calling up & down
#1094
Conversation
|
I want to second this proposal as I also often need to chain |
HeyNonster
force-pushed
the
nony--show-src-lines-up-down
branch
from
c07fda0 to
caec1c5
Compare
|
Also probably useful to note that byebug-vs-debug.mov |
HeyNonster
force-pushed
the
nony--show-src-lines-up-down
branch
from
caec1c5 to
b1963e7
Compare
Launchable Report❌ Test session #2907805 failed ❌ Test session #2907807 failed Passed test sessions✅ Test session #2907791 passed Build: refs_pull_1094_merge_b1963e7b72554c9672900ba046c3088598955488 |
|
Seems the protocol tests are flaky: #1060 |
HeyNonster
force-pushed
the
nony--show-src-lines-up-down
branch
from
b1963e7 to
a1df646
Compare
Both `up` and `down` only show 1 source line when called, I think it would be more useful if they provided more context. This removes the `max_lines: 1` kwarg when they call `show_src`. `max_lines` in `show_src` will default to `CONFIG[:show_src_lines]`[^1]. [^1]:(https://github.com/ruby/debug/blob/0b77e8294b5b220b3b2a089bf09f94808654899a/lib/debug/thread_client.rb#L510)
HeyNonster
force-pushed
the
nony--show-src-lines-up-down
branch
from
a1df646 to
98a7521
Compare
|
Maybe we need to introduce another configuration. |
3 participants
Description
Both
upanddownonly show 1 source line when called, I think it would be more useful if they provided more context. This removes themax_lines: 1kwarg when they callshow_src.max_linesinshow_srcwill default toCONFIG[:show_src_lines]1.Big thanks to @st0012 for showing me and @bquorning where this behavior is defined.
Footnotes
(https://github.com/ruby/debug/blob/0b77e8294b5b220b3b2a089bf09f94808654899a/lib/debug/thread_client.rb#L510) ↩